FAB-18198 Ch.Part.API: Restructure registrar init #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Registrar now operates either with or without a system channel. This creates two distinct (but slightly overlapping) initialization flows. Here we restructure the Registrar initialization such that it is clear which methods are common to both flows, and which methods belong to the flow with or without the system channel. For example, the current `initAppChannels` is split in two: - initAppChannelsWithSystemChannel(), which assume the system channel exists, and - initAppChannels(), which assumes the system channel does not exist. This simplifies the code and makes it more readable, and tries to be considerate of the fact that hopefully we'll be able to remove the system channel related code (after the system channel functionality is deprecated) so isolating it helps us later down the line. Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: I21b2e495745fec0859e2af998019b0a496e977e6
C0rWin
approved these changes
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Registrar now operates either with or without a system channel.
This creates two distinct (but slightly overlapping) initialization
flows. Here we restructure the Registrar initialization such that it
is clear which methods are common to both flows, and which methods
belong to the flow with or without the system channel.
For example, the current
initAppChannelsis split in two:This simplifies the code and makes it more readable, and tries to be
considerate of the fact that hopefully we'll be able to remove
the system channel related code (after the system channel functionality
is deprecated) so isolating it helps us later down the line.
Signed-off-by: Yoav Tock tock@il.ibm.com
Change-Id: I21b2e495745fec0859e2af998019b0a496e977e6
Type of change
Related issues
Task: FAB-18198
Epic: FAB-17712